Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set ARCH_FLAG before compiler/linker flag checks #4457

Closed
wants to merge 1 commit into from
Closed

build: set ARCH_FLAG before compiler/linker flag checks #4457

wants to merge 1 commit into from

Conversation

xiphon
Copy link
Contributor

@xiphon xiphon commented Sep 27, 2018

There are some architecture-dependent compiler flags. We have to set ARCH_FLAG before we do any flag checks, e.g., GCC doesn't support fcf_protection for x86 targets.

Cross-compilation output (gcc 8.2.0) without the fix:

-- Building on x86_64 for i686
-- Performing Test _fcf_protection=full_c
-- Performing Test _fcf_protection=full_c - Success
-- Performing Test _fcf_protection=full_cxx
-- Performing Test _fcf_protection=full_cxx - Success

...

cc1plus: error: ‘-fcf-protection=full’ is not supported for this target

fluffypony
fluffypony approved these changes Sep 29, 2018
View reviewed changes
Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

fluffypony added a commit that referenced this pull request Sep 29, 2018
@fluffypony
Merge pull request #4457
37252f6 
85318e7 build: set ARCH_FLAG before compiler/linker flag checks (xiphon)
fluffypony added a commit that referenced this pull request Sep 29, 2018
@fluffypony
Merge pull request #4457
4e3bff9 
85318e7 build: set ARCH_FLAG before compiler/linker flag checks (xiphon)
@fluffypony fluffypony closed this Sep 30, 2018
@xiphon xiphon deleted the fix-compiler-flags-arch branch October 4, 2018 00:05
@stoffu stoffu mentioned this pull request Dec 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moneromooo-monero moneromooo-monero moneromooo-monero approved these changes

@TheCharlatan TheCharlatan TheCharlatan approved these changes

@fluffypony fluffypony fluffypony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiphon @fluffypony @TheCharlatan @moneromooo-monero