Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random minor fixes #4459

Closed
wants to merge 20 commits into from
Closed

Random minor fixes #4459

wants to merge 20 commits into from

Conversation

moneromooo-monero
Copy link
Collaborator

No description provided.

@moneromooo-monero
blockchain_blackball: fix shift range for 32 bit archs
c57a65b 
Coverity 188406
@moneromooo-monero
simplewallet: top level exception catcher to print nicer messages
02563bf 
Coverity 188408
@moneromooo-monero
unit_tests: use std::shared_ptr to shut coverity up about leaks
d8b1ec8 
Coverity 188436, 188433, 188428, 188415, 188416, 188410, 188400,
188298, 188299, 188321, 188342, 188343, 188355, 188357, 188361,
188366, 188374
@moneromooo-monero
unit_tests: add check for page size > 0 before dividing
a085da3 
Coverity 188426
@moneromooo-monero
performance_test: fix bad last argument calling add_arg
7ece155 
Coverity 182572
@moneromooo-monero moneromooo-monero changed the title Cov8 Random minor fixes Sep 27, 2018
coneiric
coneiric reviewed Sep 27, 2018
View reviewed changes
tests/unit_tests/mlocker.cpp
delete m0;
delete m1;
delete m2;
m0 = NULL;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe m0.reset(nullptr);?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just how I'm used to seeing smart-pointers reset, think it has same effect.

src/blockchain_db/lmdb/db_lmdb.cpp Outdated
mdb_stat(txn, m_block_info, &ms);
result = mdb_stat(txn, m_block_info, &ms);
if (result)
throw0(DB_ERROR(lmdb_error("Failed to query hf_versions table: ", result).c_str()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

el00ruobuob
el00ruobuob reviewed Sep 27, 2018
View reviewed changes
external/easylogging++/easylogging++.cc Outdated
@@ -1977,9 +1977,9 @@ void VRegistry::setCategories(const char* categories, bool clear) {
}
if (!m_categoriesString.empty())
m_categoriesString += ",";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add the , only if categories isn't empty too? Otherwise it would add a useless , at the end of m_categoriesString.

@moneromooo-monero
easylogging++: test for NULL before dereference
5fdcda5
@moneromooo-monero
mlog: don't remove old logs if we failed to rename the current file
661439f 
Coverity 188348
@moneromooo-monero
blockchain_blackball: catch failure to commit db transaction
e67016d 
Coverity 188349
@moneromooo-monero
db_lmdb: catch error in mdb_stat calls during migration
53df2de 
Coverity 188305
@moneromooo-monero
gen_multisig: nice exit on unhandled exception
6e85542 
Coverity 182569
@moneromooo-monero
threadpool: do not propagate exceptions through the dtor
ea7f954 
This would call terminate.
We ignore exceptions in pthread_join instead, as this is not
a fatal problem here.

Coverity 182568
@moneromooo-monero
unit_tests: catch unhandled exceptions
418a993 
Coverity 182560
@moneromooo-monero
wallet_rpc_server: exit cleanly on unhandled exceptions
1b0afee 
Coverity 161868
@moneromooo-monero
db_lmdb: do not propagate exceptions in dtor
0749a8b 
Not much we can do here

Coverity 161875
@moneromooo-monero
Copy link
Collaborator Author

Plus a few more.

@moneromooo-monero
fuzz_tests: catch unhandled exceptions
bcf3f6a 
Coverity 175293, 175312, 175266
fluffypony
fluffypony approved these changes Sep 29, 2018
View reviewed changes
Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

fluffypony added a commit that referenced this pull request Sep 29, 2018
@fluffypony
Merge pull request #4459
f0b3bbf 
bcf3f6a fuzz_tests: catch unhandled exceptions (moneromooo-monero)
3ebd05d miner: restore stream flags after changing them (moneromooo-monero)
a093092 levin_protocol_handler_async: do not propagate exception through dtor (moneromooo-monero)
1eebb82 net_helper: do not propagate exceptions through dtor (moneromooo-monero)
fb6a363 miner: do not propagate exceptions through dtor (moneromooo-monero)
2e2139f epee: do not propagate exception through dtor (moneromooo-monero)
0749a8b db_lmdb: do not propagate exceptions in dtor (moneromooo-monero)
1b0afee wallet_rpc_server: exit cleanly on unhandled exceptions (moneromooo-monero)
418a993 unit_tests: catch unhandled exceptions (moneromooo-monero)
ea7f954 threadpool: do not propagate exceptions through the dtor (moneromooo-monero)
6e85542 gen_multisig: nice exit on unhandled exception (moneromooo-monero)
53df2de db_lmdb: catch error in mdb_stat calls during migration (moneromooo-monero)
e67016d blockchain_blackball: catch failure to commit db transaction (moneromooo-monero)
661439f mlog: don't remove old logs if we failed to rename the current file (moneromooo-monero)
5fdcda5 easylogging++: test for NULL before dereference (moneromooo-monero)
7ece155 performance_test: fix bad last argument calling add_arg (moneromooo-monero)
a085da3 unit_tests: add check for page size > 0 before dividing (moneromooo-monero)
d8b1ec8 unit_tests: use std::shared_ptr to shut coverity up about leaks (moneromooo-monero)
02563bf simplewallet: top level exception catcher to print nicer messages (moneromooo-monero)
c57a65b blockchain_blackball: fix shift range for 32 bit archs (moneromooo-monero)
fluffypony added a commit that referenced this pull request Sep 29, 2018
@fluffypony
Merge pull request #4459
effcbf2 
bcf3f6a fuzz_tests: catch unhandled exceptions (moneromooo-monero)
3ebd05d miner: restore stream flags after changing them (moneromooo-monero)
a093092 levin_protocol_handler_async: do not propagate exception through dtor (moneromooo-monero)
1eebb82 net_helper: do not propagate exceptions through dtor (moneromooo-monero)
fb6a363 miner: do not propagate exceptions through dtor (moneromooo-monero)
2e2139f epee: do not propagate exception through dtor (moneromooo-monero)
0749a8b db_lmdb: do not propagate exceptions in dtor (moneromooo-monero)
1b0afee wallet_rpc_server: exit cleanly on unhandled exceptions (moneromooo-monero)
418a993 unit_tests: catch unhandled exceptions (moneromooo-monero)
ea7f954 threadpool: do not propagate exceptions through the dtor (moneromooo-monero)
6e85542 gen_multisig: nice exit on unhandled exception (moneromooo-monero)
53df2de db_lmdb: catch error in mdb_stat calls during migration (moneromooo-monero)
e67016d blockchain_blackball: catch failure to commit db transaction (moneromooo-monero)
661439f mlog: don't remove old logs if we failed to rename the current file (moneromooo-monero)
5fdcda5 easylogging++: test for NULL before dereference (moneromooo-monero)
7ece155 performance_test: fix bad last argument calling add_arg (moneromooo-monero)
a085da3 unit_tests: add check for page size > 0 before dividing (moneromooo-monero)
d8b1ec8 unit_tests: use std::shared_ptr to shut coverity up about leaks (moneromooo-monero)
02563bf simplewallet: top level exception catcher to print nicer messages (moneromooo-monero)
c57a65b blockchain_blackball: fix shift range for 32 bit archs (moneromooo-monero)
@fluffypony fluffypony closed this Sep 30, 2018
@stoffu stoffu mentioned this pull request Jun 19, 2020
Merged
@stoffu stoffu mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@el00ruobuob el00ruobuob el00ruobuob left review comments

@coneiric coneiric coneiric approved these changes

@xiphon xiphon xiphon approved these changes

@fluffypony fluffypony fluffypony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moneromooo-monero @fluffypony @xiphon @coneiric @el00ruobuob