-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 32bit depends builds for linux and windows #4470
Closed
TheCharlatan
wants to merge
1
commit into
monero-project:release-v0.13
from
TheCharlatan:release32Bit
Closed
Fix 32bit depends builds for linux and windows #4470
TheCharlatan
wants to merge
1
commit into
monero-project:release-v0.13
from
TheCharlatan:release32Bit
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add architecture flags when cmake invokes gcc manually. Add 32bit to Travis.
#4472 refactors libblocks, |
moneromooo-monero
approved these changes
Sep 30, 2018
fluffypony
approved these changes
Oct 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
fluffypony
added a commit
that referenced
this pull request
Oct 2, 2018
2fbf38e Fix 32bit depends builds (TheCharlatan) 17142ec malloc scratchpad for all supported android archs (m2049r) 6a78140 Make depends use self built clang for darwin (TheCharlatan) 69da14e fixes make debug compilation on OSX (Dusan Klinec) fe12564 Fixup RENAME_DB() macro (Howard Chu) b297292 osx compilation fix: missing boost libs added (Dusan Klinec) 174f31b simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero) 8928886 README: mention ASAN usage alongside valgrind (moneromooo-monero) 83debef wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero) a69271f Fixed a typo (Piotr Kąkol) 92d1da2 unit_tests: fix build with GCC 5.4.0 on ubuntu (moneromooo-monero) a21da90 Wallet: use unique_ptr for WalletImpl members (oneiric) 7a056f4 WalletAPI: multisigSignData bug fixed (naughtyfox) 43a0635 ringdb: use cursors to be a bit faster (moneromooo-monero) 7964d4f wallet2: handle corner case in picking fake outputs (moneromooo-monero) 6f5360b bump version to 0.13.0.1 (Riccardo Spagni) cf470bf switch from master to rc (Riccardo Spagni)
fluffypony
added a commit
that referenced
this pull request
Oct 2, 2018
2fbf38e Fix 32bit depends builds (TheCharlatan) 17142ec malloc scratchpad for all supported android archs (m2049r) 6a78140 Make depends use self built clang for darwin (TheCharlatan) 69da14e fixes make debug compilation on OSX (Dusan Klinec) fe12564 Fixup RENAME_DB() macro (Howard Chu) b297292 osx compilation fix: missing boost libs added (Dusan Klinec) 174f31b simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero) 8928886 README: mention ASAN usage alongside valgrind (moneromooo-monero) 83debef wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero) a69271f Fixed a typo (Piotr Kąkol) 92d1da2 unit_tests: fix build with GCC 5.4.0 on ubuntu (moneromooo-monero) a21da90 Wallet: use unique_ptr for WalletImpl members (oneiric) 7a056f4 WalletAPI: multisigSignData bug fixed (naughtyfox) 43a0635 ringdb: use cursors to be a bit faster (moneromooo-monero) 7964d4f wallet2: handle corner case in picking fake outputs (moneromooo-monero) 6f5360b bump version to 0.13.0.1 (Riccardo Spagni) cf470bf switch from master to rc (Riccardo Spagni)
fotolockr
pushed a commit
to fotolockr/monero
that referenced
this pull request
May 1, 2019
2fbf38e Fix 32bit depends builds (TheCharlatan) 17142ec malloc scratchpad for all supported android archs (m2049r) 6a78140 Make depends use self built clang for darwin (TheCharlatan) 69da14e fixes make debug compilation on OSX (Dusan Klinec) fe12564 Fixup RENAME_DB() macro (Howard Chu) b297292 osx compilation fix: missing boost libs added (Dusan Klinec) 174f31b simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero) 8928886 README: mention ASAN usage alongside valgrind (moneromooo-monero) 83debef wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero) a69271f Fixed a typo (Piotr Kąkol) 92d1da2 unit_tests: fix build with GCC 5.4.0 on ubuntu (moneromooo-monero) a21da90 Wallet: use unique_ptr for WalletImpl members (oneiric) 7a056f4 WalletAPI: multisigSignData bug fixed (naughtyfox) 43a0635 ringdb: use cursors to be a bit faster (moneromooo-monero) 7964d4f wallet2: handle corner case in picking fake outputs (moneromooo-monero) 6f5360b bump version to 0.13.0.1 (Riccardo Spagni) cf470bf switch from master to rc (Riccardo Spagni)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add architecture flags when cmake invokes gcc manually. This is a raw fix, but does not actually deal with the underlying problem. Adds 32bit targets to travis. The travis builds run fine now, however hidapi still remains statically linked, as described in #4453 .