Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32bit depends builds for linux and windows #4470

Closed

Conversation

TheCharlatan
Copy link
Contributor

Add architecture flags when cmake invokes gcc manually. This is a raw fix, but does not actually deal with the underlying problem. Adds 32bit targets to travis. The travis builds run fine now, however hidapi still remains statically linked, as described in #4453 .

Add architecture flags when cmake invokes gcc manually.
Add 32bit to Travis.
@xiphon
Copy link
Contributor

xiphon commented Sep 29, 2018

#4472 refactors libblocks, LD -r -b binary custom command won't be used anymore

Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

fluffypony added a commit that referenced this pull request Oct 2, 2018
2fbf38e Fix 32bit depends builds (TheCharlatan)
17142ec malloc scratchpad for all supported android archs (m2049r)
6a78140 Make depends use self built clang for darwin (TheCharlatan)
69da14e fixes make debug compilation on OSX (Dusan Klinec)
fe12564 Fixup RENAME_DB() macro (Howard Chu)
b297292 osx compilation fix: missing boost libs added (Dusan Klinec)
174f31b simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
8928886 README: mention ASAN usage alongside valgrind (moneromooo-monero)
83debef wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
a69271f Fixed a typo (Piotr Kąkol)
92d1da2 unit_tests: fix build with GCC 5.4.0 on ubuntu (moneromooo-monero)
a21da90 Wallet: use unique_ptr for WalletImpl members (oneiric)
7a056f4 WalletAPI: multisigSignData bug fixed (naughtyfox)
43a0635 ringdb: use cursors to be a bit faster (moneromooo-monero)
7964d4f wallet2: handle corner case in picking fake outputs (moneromooo-monero)
6f5360b bump version to 0.13.0.1 (Riccardo Spagni)
cf470bf switch from master to rc (Riccardo Spagni)
fluffypony added a commit that referenced this pull request Oct 2, 2018
2fbf38e Fix 32bit depends builds (TheCharlatan)
17142ec malloc scratchpad for all supported android archs (m2049r)
6a78140 Make depends use self built clang for darwin (TheCharlatan)
69da14e fixes make debug compilation on OSX (Dusan Klinec)
fe12564 Fixup RENAME_DB() macro (Howard Chu)
b297292 osx compilation fix: missing boost libs added (Dusan Klinec)
174f31b simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
8928886 README: mention ASAN usage alongside valgrind (moneromooo-monero)
83debef wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
a69271f Fixed a typo (Piotr Kąkol)
92d1da2 unit_tests: fix build with GCC 5.4.0 on ubuntu (moneromooo-monero)
a21da90 Wallet: use unique_ptr for WalletImpl members (oneiric)
7a056f4 WalletAPI: multisigSignData bug fixed (naughtyfox)
43a0635 ringdb: use cursors to be a bit faster (moneromooo-monero)
7964d4f wallet2: handle corner case in picking fake outputs (moneromooo-monero)
6f5360b bump version to 0.13.0.1 (Riccardo Spagni)
cf470bf switch from master to rc (Riccardo Spagni)
@fluffypony fluffypony closed this Oct 2, 2018
@TheCharlatan TheCharlatan deleted the release32Bit branch October 17, 2018 12:00
fotolockr pushed a commit to fotolockr/monero that referenced this pull request May 1, 2019
2fbf38e Fix 32bit depends builds (TheCharlatan)
17142ec malloc scratchpad for all supported android archs (m2049r)
6a78140 Make depends use self built clang for darwin (TheCharlatan)
69da14e fixes make debug compilation on OSX (Dusan Klinec)
fe12564 Fixup RENAME_DB() macro (Howard Chu)
b297292 osx compilation fix: missing boost libs added (Dusan Klinec)
174f31b simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
8928886 README: mention ASAN usage alongside valgrind (moneromooo-monero)
83debef wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
a69271f Fixed a typo (Piotr Kąkol)
92d1da2 unit_tests: fix build with GCC 5.4.0 on ubuntu (moneromooo-monero)
a21da90 Wallet: use unique_ptr for WalletImpl members (oneiric)
7a056f4 WalletAPI: multisigSignData bug fixed (naughtyfox)
43a0635 ringdb: use cursors to be a bit faster (moneromooo-monero)
7964d4f wallet2: handle corner case in picking fake outputs (moneromooo-monero)
6f5360b bump version to 0.13.0.1 (Riccardo Spagni)
cf470bf switch from master to rc (Riccardo Spagni)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants