-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
functional_tests: fix linking on Windows #4492
functional_tests: fix linking on Windows #4492
Conversation
Should this be detected, or is this a "standard" thing ? |
One of the commits merged today causes performance_tests linking to fail in MSYS2.
All three undefined references are provided by bcrypt library, according to Microsoft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, maybe someone will come up with that. This patch fixes at least one machine, let's see if it breaks another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
7f2ad1a functional_tests: fix linking on Windows (iDunk5400)
7f2ad1a functional_tests: fix linking on Windows (iDunk5400)
7f2ad1a functional_tests: fix linking on Windows (iDunk5400)
No description provided.