CMakeLists.txt: add -lpthread where necessary #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moneromooo-monero
force-pushed
the
pth
branch
from
0d66951
to
ae4f1bc
Compare
|
Changed to check whether libpthread is actually here too, just in case. |
|
This isn't a good idea. Should just use "-pthread" instead; the compiler already knows whether a libpthread exists. |
The cmake thread detection just ain't enough to always work
moneromooo-monero
force-pushed
the
pth
branch
from
ae4f1bc
to
938476c
Compare
xiphon
approved these changes
Oct 14, 2018
fluffypony
added a commit
that referenced
this pull request
Oct 26, 2018
938476c CMakeLists.txt: detect and use -pthread compiler flag (moneromooo-monero)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.