Add building with depends to the Makefile #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends can now be compiled with `make depends target=$triple`, where $triple is one of the supported build targets. Adapt the Makefile for this change, remove not needed windows deps from depends setup description.
| @@ -41,6 +41,10 @@ endif | |||
|
|
|||
| all: release-all | |||
|
|
|||
| depends: | |||
| cd contrib/depends && $(MAKE) HOST=$(target) && cd ../.. && mkdir -p build/$(target)/release | |||
There was a problem hiding this comment.
HOST=$(target) ? That seems like a possible mixup.
There was a problem hiding this comment.
It's correct :)
Target is specified on the command line make depends target=..., HOST is the... target that will run the binaries..
There was a problem hiding this comment.
OK, thanks for confirming.
iDunk5400
approved these changes
Oct 16, 2018
moneromooo-monero
approved these changes
Oct 16, 2018
fluffypony
added a commit
that referenced
this pull request
Oct 26, 2018
e623f2b Add building with depends to the Makefile (TheCharlatan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends can now be compiled with
make depends target=$triple, where$triple is one of the supported build targets.
Adapt the Makefile for this change, remove not needed windows deps from
depends setup description.