Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http -> https #4900

Merged
merged 1 commit into from
Dec 12, 2018
Merged

http -> https #4900

merged 1 commit into from
Dec 12, 2018

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Nov 24, 2018

No description provided.

@moneromooo-monero
Copy link
Collaborator

I assume you've checked those download still work ?

@rex4539
Copy link
Contributor Author

rex4539 commented Nov 24, 2018

I checked them manually one by one.

The version tried to be downloaded in Qt (5.7.1) is not available anymore but that's a separate issue not related to this PR.

@TheCharlatan
Copy link
Contributor

Can you change the qt url to https://download.qt.io/archive/qt/5.7/5.7.1/submodules while you are at it?

hyc
hyc reviewed Nov 24, 2018
View reviewed changes
contrib/depends/packages/bdb.mk
@@ -1,6 +1,6 @@
package=bdb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh... Why is BDB a dependency?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BDB is still an option in the main CMakefile as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a branch where the bdb package is removed, but since there are references to it all over the codebase, I think a general removal of it would make more sense.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's never selected. I'd be fine with it being removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there are a reason for keeping bdb around in the code?

@rex4539
Copy link
Contributor Author

rex4539 commented Nov 24, 2018

Can you change the qt url to https://download.qt.io/archive/qt/5.7/5.7.1/submodules while you are at it?

Done.

@TheCharlatan TheCharlatan mentioned this pull request Nov 24, 2018
Merged
fluffypony
fluffypony approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@fluffypony fluffypony merged commit 4f74a31 into monero-project:master Dec 12, 2018
fluffypony added a commit that referenced this pull request Dec 12, 2018
@fluffypony
Merge pull request #4900
2dd6fe4 
4f74a31 http -> https (Dimitris Apostolou)
@rex4539 rex4539 deleted the http2https branch December 12, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyc hyc hyc left review comments

@TheCharlatan TheCharlatan TheCharlatan approved these changes

@moneromooo-monero moneromooo-monero moneromooo-monero approved these changes

@fluffypony fluffypony fluffypony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rex4539 @moneromooo-monero @TheCharlatan @hyc @fluffypony