Do not fall over when refreshing balance fails #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monero-project
pushed a commit
that referenced
this pull request
Jun 30, 2014
Do not fall over when refreshing balance fails
stoffu
pushed a commit
to stoffu/monero
that referenced
this pull request
Sep 27, 2018
Bump version to 0.12.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In daemon mode, the wallet polls the blockchain daemon every 20 seconds to refresh the balance. If the blockchain daemon happens to be in "core is busy" mode then the polling fails and the wallet daemon falls over. It never tries to sync again and doesn't respond to RPC requests - its useless until restarted.
This fix lets the sync fail gracefully and retry next time.