Attempt to carve the fee from a partial payment early #7342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A user manataw on IRC complaining about a fee problem has confirmed that this patch solved his problem. |
lxop
force-pushed
the
7337-carve-fee-from-partial-output
branch
from
1ed5961 to
b9567b4
Compare
Do this for both the estimate and actual fee. monero-project#7337
lxop
force-pushed
the
7337-carve-fee-from-partial-output
branch
from
b9567b4 to
520ce1c
Compare
|
The tests are all passing, but instabilities & other external problems have prevented both CI checks from passing at the same time. As such I'm having to make meaningless changes to the branch to trigger the tests to rerun (sigh). |
This is not necessary, we will ignore failed CI if it fails for unrelated reasons :) |
selsta
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-establishes the behaviour added by #348 whereby the wallet attempts to fund the tx fee by reducing the amount of a partial payment if one exists in the tx.
Fixes: #7337