7344 Fix describe_transfer in the case of multiple transactions in the set #7349
Conversation
lxop
changed the title
| } | ||
|
|
||
| if (desc.change_amount > 0) | ||
| { | ||
| const tools::wallet2::tx_construction_data &cd0 = tx_constructions[0]; | ||
| desc.change_address = get_account_address_as_str(m_wallet->nettype(), cd0.subaddr_account > 0, cd0.change_dts.addr); | ||
| res.summary.change_address = desc.change_address; |
There was a problem hiding this comment.
That address, if any, could be different for all txes.
There was a problem hiding this comment.
If that were the case an error would be triggered on line 1278, so it is safe to assume all change goes to one address here.
@moneromooo-monero I renamed |
|
Can you bump WALLET_RPC_VERSION_MINOR ? |
|
Thanks, please squash your commits and then we can add this to the merge list. |
This ensures each list of recipients is only the recipients for one transaction. It also adds a new field "summary" that describes the txset as a whole. Fixes monero-project#7344
lxop
force-pushed
the
7344-describe_transfer-fix-multiple-tx-case
branch
from
e505449 to
bf751f4
Compare
|
@lxop could you please rebase? src/wallet/wallet_rpc_server.cpp conflicts due to a recent merge |
|
ping @lxop, I would appreciate it if you could rebase so that we can merge this. |
describe_transferthat includes the total amounts and the aggregated set of recipients.Fixes #7344