[RELEASE] epee: fix mlog filename compare bug. #9396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a relative path for the log filename, since the iteration on files adds "./" to the beginning of the filename monero-wallet-rpc and monero-wallet-cli cannot find already written log files and therefore rotate indefinitely.
|
For some reason CI triggered abseil C++ build fail. Which is not related to PR, and PR is not using any external build, nor includes anything new. ( I will look into this ) |
|
@0xFFFC0000 release CI failing is expected until the next round of merges |
selsta
approved these changes
Jul 14, 2024
|
Thanks @selsta . I was not aware of that. |
luigi1111
merged commit 76feeb6
into
monero-project:release-v0.18
15 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 9392