Support position independent code for amd64-64-24k amd64-51-30k #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonimal
approved these changes
Dec 18, 2017
|
Referencing monero-project/monero#2317 |
|
Ping @fluffypony @luigi1111 |
moneromooo-monero
approved these changes
Nov 10, 2019
|
@moneromooo-monero who should I ping about this? I'm not sure who has commit access to this. @Snipa22 @luigi1111 ? |
luigi1111
added a commit
that referenced
this pull request
Jan 6, 2020
83467c5 Support position independent code for amd64-64-24k amd64-51-30k (vtnerd)
luigi1111
added a commit
that referenced
this pull request
Jan 6, 2020
83467c5 Support position independent code for amd64-64-24k amd64-51-30k (vtnerd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@luigi1111 @hyc @kenshi84 @anonimal
I didn't rename the last PR - it contained unmodified supercop code. This contains edits to make the ASM files position independent so that it works in libraries compiled with
-fPICand executables compiled with-fPIE. OSX defaults to both (at least on my test box).Only the files necessary to get wallet scanning have been modified. I am also unaware of any timing issues as a result of this change.
EDIT: Note this is the
monerobranch, themasterbranch will be kept clean and only contain direct supercop code.