remove HKT in typescript bindings, fix TS 2.4 support #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove typescript binding bits which assume higher-kinded types support: those bits break with typescript 2.4. Fixes #144 the library now builds OK with typescript 2.4+.
It's a shame to lose this but that's the language we have. See my latest comment in #144.
@estaub suggested in #144 to keep the interfaces but just comment their contents, but I don't see the point. We can explain the interfaces in the documentation, no need to list them in the .d.ts files I guess.
I also noticed that it seems we don't anymore ship the generated files in git? That would mean two things:
CONTRIBUTING.md
is outdated because it suggests to runnpm run publ
"monet": "https://github.com/cwmyers/monet.js/tarball/575dafec572b7e01bc9071ee969a7f9771207964"
. That's a letdown because monet is not released very often. If that's true and you accept this PR, I suggest to release a new alpha quickly after pulling this PR so people depending on monet can migrate to TS 2.4 -- previously they could have done it by referring to a git tag, but now they could be stuck