Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove HKT in typescript bindings, fix TS 2.4 support #147

Closed
wants to merge 1 commit into from

Conversation

emmanueltouzery
Copy link
Collaborator

remove typescript binding bits which assume higher-kinded types support: those bits break with typescript 2.4. Fixes #144 the library now builds OK with typescript 2.4+.

It's a shame to lose this but that's the language we have. See my latest comment in #144.

@estaub suggested in #144 to keep the interfaces but just comment their contents, but I don't see the point. We can explain the interfaces in the documentation, no need to list them in the .d.ts files I guess.

I also noticed that it seems we don't anymore ship the generated files in git? That would mean two things:

  1. the CONTRIBUTING.md is outdated because it suggests to run npm run publ
  2. according to my understanding, it's now impossible for an application to depend on a git tag of monet, like this for instance "monet": "https://github.com/cwmyers/monet.js/tarball/575dafec572b7e01bc9071ee969a7f9771207964". That's a letdown because monet is not released very often. If that's true and you accept this PR, I suggest to release a new alpha quickly after pulling this PR so people depending on monet can migrate to TS 2.4 -- previously they could have done it by referring to a git tag, but now they could be stuck

@emmanueltouzery emmanueltouzery requested review from WojciechP and ulfryk and removed request for ulfryk and WojciechP August 13, 2017 12:12
@ulfryk
Copy link
Member

ulfryk commented Aug 16, 2017

It's rather painful regression… I'll try to figure out some less destructive solution. If I don't manage to deliver it within days, I'll approve and merge your PR.

Ad. 1 - you are right -- will fix it with release.
Ad. 2 - will do that as soon as some solution is merged.

Thanks for investigation and your work :)

@emmanueltouzery
Copy link
Collaborator Author

sure. Do read what I wrote there:
#144 (comment)

specifically the solution that the fp-ts library is using. The author wrote a whole blog post on this issue!

@emmanueltouzery
Copy link
Collaborator Author

this PR is probably obsolete since monet appears to compile fine with recent typescript@next (future typescript 2.6) versions...

@ulfryk ulfryk mentioned this pull request Nov 2, 2017
@ulfryk
Copy link
Member

ulfryk commented Nov 2, 2017

see #149

@ulfryk ulfryk closed this Nov 2, 2017
@ulfryk ulfryk deleted the no_more_hkt_typescript branch June 18, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants