forked from flutter/packages
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[go_router] Fix missing build parameter in type-safe routes topic doc…
…umentation (flutter#5040) Added the missing GoRouterState state parameter to the build methods of `HomeScreenRoute` and `SongRoute`, to the type-safe routes [topic](https://github.com/flutter/packages/blob/main/packages/go_router/doc/type-safe-routes.md). Using the current documentation (without the fix), raises the error: ``` dart 'HomeScreenRoute.build' ('Widget Function(BuildContext)') isn't a valid override of 'GoRouteData.build' ('Widget Function(BuildContext, GoRouterState)') ``` I didn't find any issue for this, but if you'd want I could simply open one myself and link it to this pull request.
- Loading branch information
Showing
3 changed files
with
7 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters