Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when trying to use-lan-ip #68

Closed
tomhicks opened this issue Jul 12, 2017 · 0 comments · Fixed by #69
Closed

Error when trying to use-lan-ip #68

tomhicks opened this issue Jul 12, 2017 · 0 comments · Fixed by #69
Assignees
@tanuck
Labels
bug

Comments

@tomhicks
Copy link

Navy tries to do stuff with non-navies when running certain commands. It should check whether the item it is trying to work with in ~/.navy/navies is a directory before working on it.

> navy use-lan-ip

 • Reconfiguring .DS_Store FAILED


 ERROR

 Navy ".DS_Store" not imported

 Make sure you've imported the navy with navy import
@ThomWright ThomWright added the bug label Jul 12, 2017
@tanuck tanuck self-assigned this Jul 13, 2017
tanuck added a commit that referenced this issue Jul 13, 2017
@tanuck
getLaunchedNavies now validates that a navy path is a directory
f222723 
Calls to Navy.safeGetDriver within various methods were throwing
an Error when that navies directory contained a file. One example
being the unintended existence of a .DS_Store file on MacOS.
getLaunchedNavies now filters out all non-directory nodes. Manually
creating an empty directory instead would still surface the problem,
however this would be a seen as an intentional corruption of the navies
directory and the doctor command can be used to resolve this.

Fixes #68
@tanuck tanuck mentioned this issue Jul 13, 2017
Merged
@ozamarripamoneyhub ozamarripamoneyhub mentioned this issue Apr 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanuck tanuck

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

getLaunchedNavies now validates that a navy path is a directory moneyhub/navy
3 participants
@tanuck @ThomWright @tomhicks