Fix integration testing #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration tests run in their own container and navy uses a dedicated docker daemon running in another container on the host VM. We do not pass the environment variables from the travis matrix down to the scripts that setup this testing environment. Hence until now, all test builds have been using the same version of docker and docker-compose.
|
Didn't even know about build args, thanks for this! It's worth noting that the integration tests didn't used to run in a dedicated container using dind, they used to use the host daemon directly. I changed this so that the tests would run on a consistent environment every time on both developer machines and CI. |
|
@madjam002 yeah they're pretty nice. They don't pollute the environment of the resulting image which is good. And I assumed that was the case, hence why there was all the docker-compose stuff in the travis file. Amazingly this seems to have worked first time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests run in their own container and navy
uses a dedicated docker daemon running in another container
on the host VM. We do not pass the environment variables
from the travis matrix down to the scripts that setup this
testing environment. Hence until now, all test builds have
been using the same version of docker and docker-compose.