Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(action): use setup python poetry action #31

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat(action): use setup python poetry action #31

merged 1 commit into from
Oct 30, 2023

Conversation

felix11h
Copy link
Contributor

@felix11h felix11h commented Oct 26, 2023 •
edited
Loading

Update action to use action-setup-python-poetry, in order to read Python and Poetry version from pyproject.toml. This required a change in action-setup-python-poetry, see moneymeets/action-setup-python-poetry#16.

Tests:

⚠️ moneymeets/action-setup-python-poetry#16 needs to be merged first!

@felix11h felix11h mentioned this pull request Oct 26, 2023
Merged
@felix11h felix11h marked this pull request as ready for review October 26, 2023 12:49
@felix11h felix11h requested review from marns93 and zyv October 26, 2023 12:49
zyv
zyv approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@zyv zyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also here reference an action ticket in the TODO?

@felix11h felix11h mentioned this pull request Oct 30, 2023
Merged
@felix11h
Copy link
Contributor Author

Maybe also here reference an action ticket in the TODO?

Done!

@felix11h
Copy link
Contributor Author

/rebase

@mergealot mergealot force-pushed the feature/use-action-setup-python-poetry branch from 5b33225 to 8a49daf Compare October 30, 2023 12:01
@felix11h felix11h merged commit 88ecd39 into master Oct 30, 2023
3 checks passed
@felix11h felix11h deleted the feature/use-action-setup-python-poetry branch October 30, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marns93 marns93 marns93 approved these changes

@zyv zyv zyv approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felix11h @zyv @marns93