-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn that the buildpack is deprecated + no longer required #76
Conversation
…ired This buildpack is no longer required now that the Heroku Python buildpack supports Poetry natively: - https://devcenter.heroku.com/changelog-items/3050 - heroku/heroku-buildpack-python#1682 As such, a deprecation warning has been added to both the build log and the README. The warning borrows from the implementation here (which uses colour, and also makes sure to ANSI wrap each line individually to prevent issues with streaming logs from `git push` etc): https://github.com/heroku/heroku-buildpack-python/blob/ca99c39f9e3627fff727788206f7fcc4ff064b7f/lib/output.sh#L50-L66 Closes moneymeets#75.
ba49dd7
to
5b6496f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for preparing these changes! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Thank you for the review and merge! |
I don't suppose you own the If so, would it be ok for you to push a new version there? :-)
To save having to set up the Heroku CLI (and install the buildpack registry plugin) it's possible to trigger a publish from |
@edmorley Thanks for pointing to this. This was created by my account. I've published an updated version. $ heroku buildpacks:versions moneymeets/python-poetry
Version Released At Status
─────── ──────────────────────── ─────────
3 2024-11-21T12:57:43.849Z published
2 2021-01-29T08:36:35.597Z published
1 2020-12-27T22:10:28.531Z published This is not used, so in theory I could archive this. Same will be true for this repository, we will archive this in the next few days. |
That sounds great! Thank you so much for both creating/maintaining this buildpack over the years and now helping with the transition :-) |
Archiving is also a safe operation (the assets on S3 will remain, so existing apps using it will continue to build):
|
It was our pleasure to create/maintain this buildpack and see the community using it. |
Okay, if it is a safe operation there is absolutely nothing against archiving it. Archived already :) |
This buildpack is no longer required now that the Heroku Python buildpack supports Poetry natively:
As such, a deprecation warning has been added to both the build log and the README.
The warning borrows from the implementation here (which uses colour, and also makes sure to ANSI wrap each line individually to prevent issues with streaming logs from
git push
etc):https://github.com/heroku/heroku-buildpack-python/blob/ca99c39f9e3627fff727788206f7fcc4ff064b7f/lib/output.sh#L50-L66
Closes #75.