Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(actions): remove mergealot ssh key #5

Merged
merged 1 commit into from
Oct 2, 2024
Merged

ci(actions): remove mergealot ssh key #5

merged 1 commit into from
Oct 2, 2024
+0 −2

Conversation

felix11h
Copy link
Contributor

@felix11h felix11h commented Oct 2, 2024

Reviewer

  • for your information
  • process and function, acceptance criteria
  • implementation (code design, correctness, formatting)
    • unit tests are implemented
    • E2E tests are implemented, if reasonable
  • testing
    • checklist of test cases for manual testing is created
    • all test cases are passed successfully
    • invariants are checked (what should stay the same or not be affected by the changes)

Description

@catcombo was wondering if we can remove the mergealot ssh key in https://github.com/moneymeets/moneymeets-pulumi/pull/707. I also don't see a reason why we would need it.

@felix11h felix11h requested a review from catcombo October 2, 2024 06:50
catcombo
catcombo approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@catcombo catcombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@felix11h felix11h merged commit 5e5ba9d into master Oct 2, 2024
3 checks passed
@felix11h felix11h deleted the feature/remove-mergealot-ssh-key branch October 2, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catcombo catcombo catcombo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felix11h @catcombo