Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison operation #402

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Fix comparison operation #402

merged 1 commit into from
Oct 24, 2017

Conversation

flajos
Copy link

@flajos flajos commented Sep 14, 2017

The scale (precision) parameter was missing from the comparison operation, leading to wrong results.

@flajos
Fix comparison operation
212101d 
The scale (precision) parameter was missing from the comparison operation, leading to wrong results.
@sagikazarmark sagikazarmark added area/money kind/bug Something isn't working labels Oct 24, 2017
@sagikazarmark
Copy link
Collaborator

Thanks @flajos for your contribution, sorry for the late feedback.

As far as I can see the builds are breaking because of the documentation, but that has been fixed in 1fc94fc, so I'm just going to merge your fix.

@sagikazarmark sagikazarmark merged commit 85ba0d0 into moneyphp:precise-money Oct 24, 2017
@flajos flajos deleted the patch-1 branch October 25, 2017 08:23
@flajos
Copy link
Author

flajos commented Oct 25, 2017

Thanks @sagikazarmark!
Nice work by the way 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/money kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flajos @sagikazarmark