-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update style, add menu and change chart unit #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job Bárbara!
I'm adding three extra comments here:
- The page has some vertical scroll. Do you think we could remove it?
- The highlighted countries on the map are still green instead of purple
- There are some issues with the exported image:
- The Mongabay logo and attributions to Trase are gone
- There's some extra padding at the top of the image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments:
- I hadn't realised that you changed the order of the dropdowns before and I don't think it's a good idea. A change of value in one of the dropdowns affects the options of the ones below. So it's important that we display first the source country, then the commodity, then the change unit and finally the year. In summary, I think you should bring back the previous order.
- Do you think you could make sure that CO2 is always displayed as CO₂? Look at this example.
- There are two React errors in
components/icons/index.js
because you're using thestroke-width
andstroke-linecap
props instead ofstrokeWidth
andstrokeLinecap
. - There is a further React error in
components/header/menu/index.js
due to theinert
prop. - Could you update the meta tags with the new title and description?
clementprdhomme
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Tasks
style: https://vizzuality.atlassian.net/browse/MP-176
ranking chart: https://vizzuality.atlassian.net/browse/MP-182