BAAS-16552: update goja to latest changes (part 1) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue. See dop251#340 Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 4549f2c)
With this simplified code it skips some allocations of byte slices ``` benchstat old.bench new.bench name old time/op new time/op delta ASCIIConcat-8 44.3µs ± 5% 40.2µs ±12% -9.18% (p=0.000 n=10+10) name old alloc/op new alloc/op delta ASCIIConcat-8 14.0kB ± 0% 9.9kB ± 0% -29.28% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ASCIIConcat-8 131 ± 0% 121 ± 0% -7.63% (p=0.000 n=10+10) ``` Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 989602c)
…or messages. Fixes dop251#343 Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 1309139)
…uplicate names. Fixes dop251#344. Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 676aa9f)
… but widely implemented Error.stack property. Closes dop251#337. Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 100e3a1)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit dd589aa)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 0bc6d0e)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 68467fa)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 06ae6b2)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 3649f4d)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 6e6f57d)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 336e1ad)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit d9c6733)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit f397cb3)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 1408985)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit c487fa8)
Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit d26b426)
… for the date being unset. Upgraded tc39 tests. Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 945df7a)
…ssable structs and arrays are copied in ToValue() so they remain writable in ES. Subsequent Export() returns the value including any changes made. Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 47311be)
…on-array values into slices. Fixes dop251#369, closes dop251#370. Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit 93b7349)
…o function. Do not treat callables (functions) as array-like when exporting to slices. Fixes dop251#369. Signed-off-by: Gabri <gabriele.cimato@gmail.com> (cherry picked from commit a23ee90)
|
Looks like some changes need to be pulled into this branch, but this LGTM otherwise |
kpatel71716
approved these changes
Feb 23, 2023
Comment on lines
-299
to
-316
| func toIntIgnoreNegZero(v Value) (int64, bool) { | ||
| num := v.ToNumber() | ||
| if i, ok := num.(valueInt); ok { | ||
| return int64(i), true | ||
| } | ||
| if i, ok := num.(valueInt64); ok { | ||
| return int64(i), true | ||
| } | ||
| if f, ok := num.(valueFloat); ok { | ||
| if v == _negativeZero { | ||
| return 0, true | ||
| } | ||
| if i, ok := floatToInt(float64(f)); ok { | ||
| return i, true | ||
| } | ||
| } | ||
| return 0, false | ||
| } |
There was a problem hiding this comment.
nice! This has been a minor pain historically
| @@ -367,7 +367,6 @@ func TestMemCheck(t *testing.T) { | |||
| `, | |||
| 7 + 3 + // Error "message" field + len("abc") | |||
| 4 + 5 + // Error "name" field + len("Error") | |||
| 5 + // Error "stack" field + len("") since stack is currently always set to an empty string | |||
There was a problem hiding this comment.
nice! Good too see this temporary stubbing go away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included commits
addSrcMap()whencompileVariableStatement()andcompileLexicalDeclaration()dop251/goja#353.throw "something"dop251/goja#354.Compiledop251/goja#352.parser.ParseFilehangs when parsing "`" dop251/goja#351addSrcMap()to typecompiledFunctionLiteral. dop251/goja#347.BAAS patch
Link to baas patch running against baas 🤞🏼
Our changes
nilnow.