-
Notifications
You must be signed in to change notification settings - Fork 230
chore(compass-assistant): apply patches to assistant styling COMPASS-9790 #7284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…9790 Fixes issues with: - minimum window size breaking workspaces when assistant - headings having bad spacing - assistant name not being bold - drawer opening with weird wrapping
e52c3fb
to
9654454
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR applies styling fixes to the compass assistant to address layout and presentation issues. The changes focus on preventing layout breaks when the assistant drawer is open and improving text styling consistency.
- Fix minimum window size issues that break workspaces when assistant is open
- Correct heading spacing and font weight styling in assistant chat
- Update drawer width behavior to prevent layout wrapping
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
packages/compass-workspaces/src/components/workspaces.tsx | Adds minimum width wrapper to prevent layout breaks |
packages/compass-components/src/components/drawer/drawer/drawer.styles.ts | Changes drawer width from flexible to fixed width |
packages/compass-assistant/src/assistant-chat.tsx | Updates heading styles with proper spacing and font weights |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
59cb2b3
to
509a4f5
Compare
@@ -65,6 +65,12 @@ const workspacesContentStyles = css({ | |||
minHeight: 0, | |||
}); | |||
|
|||
const workspacesSectionStyles = css({ | |||
display: 'flex', | |||
minWidth: '600px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seemed like the min size after which things start to break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes issues with: