Skip to content

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Sep 4, 2025

Fixes issues with:

  • minimum window size breaking workspaces when assistant is open
  • headings having bad spacing
  • assistant name not being bold
  • drawer opening with weird wrapping

@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 16:03
@gagik gagik requested a review from a team as a code owner September 4, 2025 16:03
…9790

Fixes issues with:
- minimum window size breaking workspaces when assistant
- headings having bad spacing
- assistant name not being bold
- drawer opening with weird wrapping
@gagik gagik force-pushed the gagik/css-fixes-asssistant branch from e52c3fb to 9654454 Compare September 4, 2025 16:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies styling fixes to the compass assistant to address layout and presentation issues. The changes focus on preventing layout breaks when the assistant drawer is open and improving text styling consistency.

  • Fix minimum window size issues that break workspaces when assistant is open
  • Correct heading spacing and font weight styling in assistant chat
  • Update drawer width behavior to prevent layout wrapping

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/compass-workspaces/src/components/workspaces.tsx Adds minimum width wrapper to prevent layout breaks
packages/compass-components/src/components/drawer/drawer/drawer.styles.ts Changes drawer width from flexible to fixed width
packages/compass-assistant/src/assistant-chat.tsx Updates heading styles with proper spacing and font weights

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gagik gagik force-pushed the gagik/css-fixes-asssistant branch from 59cb2b3 to 509a4f5 Compare September 4, 2025 18:30
@@ -65,6 +65,12 @@ const workspacesContentStyles = css({
minHeight: 0,
});

const workspacesSectionStyles = css({
display: 'flex',
minWidth: '600px',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seemed like the min size after which things start to break

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-05 at 11 15 44

Let's merge this, but I'm starting a thread in the design channel just to have a conversation about what we expect here longer term.

@gagik gagik merged commit a9e0aa1 into main Sep 5, 2025
59 checks passed
@gagik gagik deleted the gagik/css-fixes-asssistant branch September 5, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants