Skip to content

Conversation

lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Oct 2, 2025

No description provided.

@lerouxb lerouxb requested a review from a team as a code owner October 2, 2025 13:44
@lerouxb lerouxb requested review from Copilot and mabaasit October 2, 2025 13:44
@github-actions github-actions bot added the fix label Oct 2, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the provider order for the CompassAssistantProvider in the Compass Web entrypoint, addressing issue COMPASS-9918.

  • Moves CompassAssistantProvider higher in the component hierarchy
  • Relocates provider from being nested deep within CompassInstanceStorePlugin to wrapping CompassConnections

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lerouxb lerouxb requested review from gagik and gribnoysup October 2, 2025 13:44
@lerouxb lerouxb added the no release notes Fix or feature not for release notes label Oct 2, 2025
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Looks like we could update some of those functions to useCallback to avoid re-creating them on renders. I doubt we're rendering here often enough to make it really matter though.

@lerouxb lerouxb merged commit 2013a8f into main Oct 3, 2025
61 of 62 checks passed
@lerouxb lerouxb deleted the fix-web-entrypoint-provider-order branch October 3, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants