Style Edits for COMPASS-153 and COMPASS-532 #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, prevent breakage in insert document dialog as well
|
LGTM |
Updated Expand / Collapse Button Style
Rationale@fredtruman mentioned that the original full-width footer expand / collapse button might distract users when viewing documents on a larger screen. Their visual focus would unnaturally shift from left to center, as depicted in the following screenshot. I explored making the button a blue link, but this potential solution is not ideal. The link seemed more likely to take you to a new page than expand / collapse the document card. |
4 tasks
imlucas
added a commit
that referenced
this pull request
Feb 3, 2020
Evergreen: https://evergreen.mongodb.com/version/5e386060e3c3311158f8f2e2 ## Todo - [x] [COMPASS-4129](https://jira.mongodb.org/browse/COMPASS-4129) created to properly fix what this PR is working around - [x] and it has dependency on [BUILD-2932](https://jira.mongodb.org/browse/BUILD-2932): notary service dll support ## Description Rollback `electron-winstaller` to `2.5.1` for now. Don't upgrade until [BUILD-2932](https://jira.mongodb.org/browse/BUILD-2932) is done. * Fixes COMPASS-4127 * Answers BUILD-10250 ## Notes [Evergreen windows builds](https://evergreen.mongodb.com/task/10gen_compass_master_windows_package_and_publish_compass_3d7b0895c3d7ed4aada6f997286a8a57d7f835b5_20_01_31_17_33_22) started failing with the electron 6 update: ``` [2020/01/31 12:47:29.021] × Error: Error: Failed with exit code: 4294967295 -- [2020/01/31 12:47:29.021] Output: [2020/01/31 12:47:29.021] System.AggregateException: One or more errors occurred. ---> System.Exception: Failed to sign, command invoked was: '.\signtool.exe sign yes C:\Users\mci-exec\AppData\Local\SquirrelTemp\tempa\lib\net45\ffmpeg.dll' [2020/01/31 12:47:29.021] at Squirrel.Update.Program.<signPEFile>d__17.MoveNext() ``` Normally, `Failed with exit code: 4294967295` means [the signtool.exe notary service client](https://jira.mongodb.org/browse/BUILD-920) is getting a 500 service error due to an outage. However, all other OS were signing with no issues [see BUILD-10250](https://jira.mongodb.org/browse/BUILD-10250). ``` cd /cygdrive/z/data/mci/src/dist/MongoDBCompassDev-win32-x64; $ ../../signtool.exe sign yes ffmpeg.dll 2020/02/03 16:34:55 Signing service didn't return a permalink $ ../../signtool.exe sign yes libEGL.dll 2020/02/03 16:35:14 Signing service didn't return a permalink $ ../../signtool.exe sign yes MongoDBCompassDev.exe Worked $ ../../signtool.exe sign yes Squirrel.exe Worked ``` So, it can't be a service issue and must be something related to the changes to `hadron-build` for COMPASS-3933 electron 6 support. Only a handful of commits and [e3ff85c9303bc43e56976226d10d6b9897324b66](mongodb-js/hadron-build@e3ff85c) `electron-winstaller` was upgraded from `2.5.1` to `4.0.0`. This changed the effective version of the [Squirrel.Windows](https://github.com/Squirrel/Squirrel.Windows) framework electron uses for win32 auto-update: * `electron-winstaller@2.5.1.` ➡️ [squirrel.windows@1.5.1](https://github.com/Squirrel/Squirrel.Windows/releases/tag/1.5.1) * `electron-winstaller@>=3.0.0` ➡️ [squirrel.windows@1.9.1](https://github.com/Squirrel/Squirrel.Windows/releases/tag/1.9.1) In `electron-winstaller@2.5.2` ➡️ [squirrel.windows@1.5.2](https://github.com/Squirrel/Squirrel.Windows/releases/tag/1.5.2): > ### Releasify now disallows non-Semver versions > > While using non-Semver versions in your NuGet package was always incorrect and resulted in undefined behavior, due to #868, these are now a full non-starter. We now require packages to have Semver-compatible versions names. Note that this doesn't affect your EXE versions, which can still use all four Win32 version numbers. > > ### Bug Fixes > > - Allow uppercase characters in SemVer versions (#924, thanks) > - Sign DLL and .node files during Releasify > - Ensure that Stub Executables pass along their parameters to the target And now the facepalm moment; [BUILD-2932](https://jira.mongodb.org/browse/BUILD-2932) (created in 2017) as the notary service doesn't support dll signing the way we need it to. ## Motivation and Context - [x] Dependency update ## Dependents mongodb-js/hadron-build#110 ## Types of changes - [x] Patch (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-153: Long Strings Breaking Text Inputs
editable-element-fieldso they don't break the page. Also adjusted max-widths particular to the insert document dialog so those fields don't break off the modal.COMPASS-532: Expand/Collapse Large Documents
text-sizeof the expand / collapse icons to vertically center the linecc: @durran @fredtruman