feat: add monorepo-tools bin as lerna replacement #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Aug 21, 2023
packages/monorepo-tools/src/utils/get-packages-in-topological-order.spec.ts
Outdated
Show resolved
Hide resolved
addaleax
approved these changes
Aug 21, 2023
lerouxb
reviewed
Aug 22, 2023
|
|
||
| const edges: [string, string][] = getEdgeList(internalPackages); | ||
|
|
||
| // if includeDependencies is specified augment the scopes with dependents |
There was a problem hiding this comment.
Is this comment (and the one below) not worded the wrong way around? 🤔
lerouxb
approved these changes
Aug 22, 2023
|
I think you might as well replace (and remove) lerna inside the root package.json for all of devtools-shared in this PR. Would act as another "test" to prove that it works. |
|
Going to close this one. The intention was to ditch lerna cause is not compatible with s390x we just list packages directly in toposorted order for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lerouxb not sure if this is too much, the filter part in
getPackagesInTopologicalOrderis probably ok, since we are maintaining it already and the added code + tests doesn't seem to be overwhelming, but do we want to have an actuallernareplacement? or something likemonorepo-packages | xargs xargs -I{} npm run -w {}(if it works everywhere)