Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell-bson-parser): Support valueOf date method #478

Conversation

benleembruggen
Copy link
Contributor

@benleembruggen benleembruggen commented Sep 29, 2024

Description

Adds support for the valueOf Date method to the shell-bson-parser package

Checklist

@mongo-J
Copy link

mongo-J commented Oct 1, 2024

Hi @mcasimir, do you know by any chance that what is the process of releasing the patch for the package or is it fully automated once pr is merged. And if there is any requirement for documentation? Also the PR checklist has a contributor license agreement does @benleembruggen need to sign this? TIA!

@Anemy
Copy link
Member

Anemy commented Oct 2, 2024

@mongo-J

what is the process of releasing the patch for the package

It's fully automated when a pr is merged. We should probably add a bit of documentation for that. I'll open a pr. The versioning (patch/minor/major) happens depending on the commit message. It uses conventional commits: https://www.conventionalcommits.org/en/v1.0.0/ This pr looks fine as is though, it will be a minor bump when merged.
Let me know if you'd like me to merge it in, not sure if you have permissions.

And if there is any requirement for documentation

We don't keep changelogs for these packages, so no. If it's a breaking change or needs a migration then it can be good to add that to a README somewhere or add a changelog describing it. In that case we also would want a major version bump, which can be indicated through a !. https://www.conventionalcommits.org/en/v1.0.0/

Also the PR checklist has a contributor license agreement does @benleembruggen need to sign this?

If they are a MongoDB employee no.

The code behind bumping packages if curious: https://github.com/mongodb-js/devtools-shared/blob/main/packages/monorepo-tools/src/bump-packages.ts

@addaleax addaleax merged commit f638b42 into mongodb-js:main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants