-
Notifications
You must be signed in to change notification settings - Fork 8
[WIP] recreate the tsc crash we're seeing in mongosh #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lerouxb
wants to merge
2
commits into
main
Choose a base branch
from
test-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,155 @@ | ||
/* eslint-disable @typescript-eslint/no-unused-vars */ | ||
import type * as schema from '../out/schema'; | ||
import type { Document } from 'bson'; | ||
|
||
interface GenericCollectionSchema { | ||
schema: Document; | ||
} | ||
interface GenericDatabaseSchema { | ||
[key: string]: GenericCollectionSchema; | ||
} | ||
interface GenericServerSideSchema { | ||
[key: string]: GenericDatabaseSchema; | ||
} | ||
type StringKey<T> = keyof T & string; | ||
|
||
class Mongo<M extends GenericServerSideSchema = GenericServerSideSchema> {} | ||
|
||
type CollectionWithSchema< | ||
M extends GenericServerSideSchema = GenericServerSideSchema, | ||
D extends GenericDatabaseSchema = M[keyof M], | ||
C extends GenericCollectionSchema = D[keyof D], | ||
N extends StringKey<D> = StringKey<D>, | ||
> = Collection<M, D, C, N> & { | ||
[k in StringKey<D> as k extends `${N}.${infer S}` ? S : never]: Collection< | ||
M, | ||
D, | ||
D[k], | ||
k | ||
>; | ||
}; | ||
|
||
class Collection< | ||
M extends GenericServerSideSchema = GenericServerSideSchema, | ||
D extends GenericDatabaseSchema = M[keyof M], | ||
C extends GenericCollectionSchema = D[keyof D], | ||
N extends StringKey<D> = StringKey<D>, | ||
> { | ||
_mongo: Mongo<M>; | ||
_database: DatabaseWithSchema<M, D>; | ||
_name: N; | ||
constructor( | ||
mongo: Mongo<M>, | ||
database: DatabaseWithSchema<M, D> | Database<M, D>, | ||
name: N, | ||
) { | ||
this._mongo = mongo; | ||
this._database = database as DatabaseWithSchema<M, D>; | ||
this._name = name; | ||
} | ||
getName(): N { | ||
return this._name; | ||
} | ||
async find( | ||
query?: schema.Query<C['schema']>, | ||
projection?: Document, | ||
options: Document = {}, | ||
): Promise<schema.Query<C['schema']> | undefined> { | ||
return Promise.resolve(query); | ||
} | ||
} | ||
|
||
type DatabaseWithSchema< | ||
M extends GenericServerSideSchema = GenericServerSideSchema, | ||
D extends GenericDatabaseSchema = GenericDatabaseSchema, | ||
> = Database<M, D> & { | ||
[k in StringKey<D>]: Collection<M, D, D[k], k>; | ||
}; | ||
|
||
function isValidCollectionName(name: string): boolean { | ||
return !!name && !/[$\0]/.test(name); | ||
} | ||
|
||
export class Database< | ||
M extends GenericServerSideSchema = GenericServerSideSchema, | ||
D extends GenericDatabaseSchema = GenericDatabaseSchema, | ||
> { | ||
_mongo: Mongo<M>; | ||
_name: StringKey<M>; | ||
_collections: Record<StringKey<D>, CollectionWithSchema<M, D>>; | ||
|
||
constructor(mongo: Mongo<M>, name: StringKey<M>) { | ||
this._mongo = mongo; | ||
this._name = name; | ||
const collections: Record< | ||
string, | ||
CollectionWithSchema<M, D> | ||
> = Object.create(null); | ||
this._collections = collections; | ||
|
||
const proxy = new Proxy(this, { | ||
get: (target, prop): any => { | ||
if (prop in target) { | ||
return (target as any)[prop]; | ||
} | ||
|
||
if ( | ||
typeof prop !== 'string' || | ||
prop.startsWith('_') || | ||
!isValidCollectionName(prop) | ||
) { | ||
return; | ||
} | ||
|
||
if (!collections[prop]) { | ||
collections[prop] = new Collection<M, D>( | ||
mongo, | ||
proxy, | ||
prop, | ||
) as CollectionWithSchema<M, D>; | ||
} | ||
|
||
return collections[prop]; | ||
}, | ||
}); | ||
return proxy; | ||
} | ||
|
||
getCollection<K extends StringKey<D>>( | ||
coll: K, | ||
): CollectionWithSchema<M, D, D[K], K> { | ||
const collection = new Collection<M, D, D['myCollection']>( | ||
this._mongo, | ||
this, | ||
'myCollection', | ||
); | ||
|
||
return collection as CollectionWithSchema<M, D, D[K], K>; | ||
} | ||
} | ||
|
||
async function run() { | ||
const serverSchema = { | ||
myDatabase: { | ||
myCollection: { | ||
schema: { | ||
_id: 'ObjectId', | ||
name: 'string', | ||
age: 'number', | ||
}, | ||
}, | ||
}, | ||
}; | ||
const mongo = new Mongo<typeof serverSchema>(); | ||
const db = new Database< | ||
typeof serverSchema, | ||
(typeof serverSchema)['myDatabase'] | ||
>(mongo, 'myDatabase') as DatabaseWithSchema< | ||
typeof serverSchema, | ||
(typeof serverSchema)['myDatabase'] | ||
>; | ||
const query = await db.myCollection.find({ name: 'foo' }); | ||
console.log(query); | ||
} | ||
|
||
run().catch(console.error); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing C['schema'] here (and in the return type) to Document does not crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly changing schema.Query to just be
any
here does not crash.Anything more complicated than that breaks.