feat(mongodb-downloader)!: use a lockfile to prevent redundant parallel downloads MONGOSH-1875 #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
changed the title
gagik
commented
Oct 10, 2025
| Object.create(null); | ||
|
|
||
| // Download mongod + mongos and return the path to a directory containing them. | ||
| async downloadMongoDbWithVersionInfo( |
There was a problem hiding this comment.
I know this is kind of a big breaking change... I am open to refactoring back but this should relatively simple migration generally and in my opinion a general improvement.
There was a problem hiding this comment.
I see the lockfile part as also a big "breaking" change (unless we make it opt-in) so I kind of see an opportunity to do this now
gagik
force-pushed
the
gagik/download-dir
branch
from
fa16082 to
20e4664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help in cases where multiple processes are trying to download Mongo binaries.
Probably needs more testing.