Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

COMPASS-3933: Upgrade to bson@4 #91

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

COMPASS-3933: Upgrade to bson@4 #91

wants to merge 4 commits into from

Conversation

imlucas
Copy link
Contributor

@imlucas imlucas commented Jan 13, 2020

Description

Merges the EJSON implementation used across Compass with the official bson legacy implementation from mongodb/js-bson#347

Motivation and Context

Updating to bson@4 for the electron upgrade so make mongodb-extended-json a wrapper around the official implementation so we're not maintaining anymore.

Todo

Types of Changes

  • Breaking (removed old dependencies and API's)

In `bson@4` `Timestamp` properties have been updated:

- `low_` ➡️ `low`
- `high_` ➡️ `high`
- sync .travis.yml
- remove old .jsfmtrc
- npm-check-updates
- prettier on test files

Note the bson@4 bump for testing/semver
Copy link

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is such a cathartic PR hah

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants