This repository was archived by the owner on Feb 4, 2022. It is now read-only.
refactor(mock-server): improve test run time across the board #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modified tests to remove 3s from test run - synchronized all destroy calls to remove need for timeout-based guess
Mock servers used to have pseudo-event loops implemented using `co`, which was somewhat confusing. Instead, a new concept of a `messageHandler` was introduced, and responses are now handled in and evented fashion. NODE-1132
This gives us more control over the process of monitoring active and removed connections in a given topology. This also allows for an event-driven approach to cleanup, whereas in the past we have depended upon timeouts. NODE-1132
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.