This repository was archived by the owner on Feb 4, 2022. It is now read-only.
fix(connection): default family to undefined rather than 4
#230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
approved these changes
Nov 20, 2017
Member
|
@jlord this is needs to be ported to 3.x as well please |
jlord
pushed a commit
that referenced
this pull request
Nov 20, 2017
jlord
pushed a commit
that referenced
this pull request
Nov 21, 2017
mbroadst
pushed a commit
that referenced
this pull request
Nov 21, 2017
* fix(connection): default `family` to undefined rather than 4 ported from #230 * chore(package lock): remove package lock * fix(connection): typo
jlord
approved these changes
Nov 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon closer inspection, #183 was actually very much backwards breaking and should not have been merged. This issue causes Automattic/mongoose#5760 via Automattic/mongoose@93e771c .
The problem with #183 is that
net.createConnection()callsdns.lookup()with thefamilyoption always set. If thefamilyoption is not set,dns.lookup()will return both ipv4 and ipv6 addresses, but since mongodb-core always setsfamilynow, the driver can only connect to ipv4 or ipv6 depending on the value offamily. In particular, this means that any user that was connecting to an ipv6 address now must specifyfamily: 6in porcelain layer >= 2.2.28 and mongoose >= 4.11.6 in order to successfully connect, whereas they didn't have to before.