This repository was archived by the owner on Feb 4, 2022. It is now read-only.
NODE-1435: move all auth to connect
#406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprahamian
suggested changes
Feb 19, 2019
|
|
||
| function connect(options, callback) { | ||
| if (AUTH_PROVIDERS == null) { | ||
| AUTH_PROVIDERS = defaultAuthProviders(options.bson); |
There was a problem hiding this comment.
Double checking that we do not allow people to change their BSON impl on the fly
mbroadst
force-pushed
the
NODE-1435/move-auth-to-connect
branch
from
19070bb to
fa99c8f
Compare
daprahamian
approved these changes
Feb 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is a little big until the previous one is reviewed and merged
This moves all authentication in the entire driver into the
connectmethod, greatly simplifying our view of auth in the module. Top-level methods still exist on all of the topologies, but they are no-ops that immediately call back with no error.