Skip to content

Defer machine ID resolution #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gagik opened this issue Apr 25, 2025 · 0 comments · May be fixed by #161
Open

Defer machine ID resolution #122

gagik opened this issue Apr 25, 2025 · 0 comments · May be fixed by #161
Assignees

Comments

@gagik
Copy link
Collaborator

gagik commented Apr 25, 2025

We're using getMachineIdSync in the global scope which blocks the entire thread at startup regardless of us using telemetry of not. native-machine-id is very quick (developed by a great team 😉) but we'd likely want to refactor our telemetry setup to instead asynchronously wait for the device ID to be resolved and cache events until then.

Similar to https://github.com/mongodb-js/mongosh/pull/2411/files#diff-d717df5f752b4b9552410572829eab7bda35a181aeff5d57eab9f07a657f25d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant