Skip to content

fix: fork coverage #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented May 2, 2025

No description provided.

@fmenezes fmenezes marked this pull request as ready for review May 2, 2025 11:28
@Copilot Copilot AI review requested due to automatic review settings May 2, 2025 11:28
@fmenezes fmenezes requested a review from a team as a code owner May 2, 2025 11:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix fork coverage issues by removing the explicit setting of commit and branch metadata from the Coveralls GitHub Action configuration.

  • Removed "git-branch" and "git-commit" parameters in the fork-specific workflow.
  • Cleaned up similar parameters in the main code health workflow to ensure consistency.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/code_health_fork.yaml Removed "git-branch" and "git-commit" to avoid issues in forked PRs
.github/workflows/code_health.yaml Removed duplicated "git-branch" and "git-commit" configuration keys
Comments suppressed due to low confidence (2)

.github/workflows/code_health_fork.yaml:88

  • Removing the 'git-branch' and similarly 'git-commit' keys can help prevent issues with forked PRs; please ensure that any downstream steps relying on these values are adjusted accordingly.
git-branch: ${{ github.head_ref || github.ref_name }}

.github/workflows/code_health.yaml:114

  • The removal of the 'git-branch' and 'git-commit' fields in this workflow aligns with the fix for fork coverage; double-check that this change does not disrupt coverage reporting for non-fork PRs if commit information is vital.
git-commit: ${{ github.event.pull_request.head.sha || github.sha }}

@fmenezes fmenezes closed this May 2, 2025
@fmenezes
Copy link
Collaborator Author

fmenezes commented May 2, 2025

this is a test, doing in #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants