chore: retry the whole test with fixtures in case of error #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a retry mechanism to OIDC integration tests to improve test reliability. The change configures vitest to retry failed OIDC tests up to 5 times, which will re-run fixtures on each retry attempt.
Key Changes:
- Added
retry: 5configuration to OIDC test cases to handle transient failures
Collaborator
Pull Request Test Coverage Report for Build 18776932526Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
gagik
approved these changes
Oct 24, 2025
| function oidcIt(name: string, cb: Parameters<OidcIt>[1]): void { | ||
| /* eslint-disable vitest/expect-expect */ | ||
| it(name, { timeout: DEFAULT_TIMEOUT }, async (context) => { | ||
| it(name, { timeout: DEFAULT_TIMEOUT, retry: 5 }, async (context) => { |
Collaborator
There was a problem hiding this comment.
is there some wait time for this? would it make sense to introduce some wait on retries?
Collaborator
Author
There was a problem hiding this comment.
vitest doesn't support wait time :( https://vitest.dev/api/#test-api-reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds a retry mechanism to OIDC tests in case the fail. It reuses the retry mechanism from vitest, which should also run fixtures.
Checklist