Skip to content

Conversation

@blva
Copy link
Collaborator

@blva blva commented Nov 10, 2025

Proposed changes

fixes perf advisor test that was checking for false isError but it's actually undefined

Checklist

@coveralls
Copy link
Collaborator

coveralls commented Nov 10, 2025

Pull Request Test Coverage Report for Build 19266996495

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.125%

Totals Coverage Status
Change from base Build 19234647238: 0.0%
Covered Lines: 6477
Relevant Lines: 7976

💛 - Coveralls

@blva blva marked this pull request as ready for review November 11, 2025 13:17
@blva blva requested a review from a team as a code owner November 11, 2025 13:17
Copilot AI review requested due to automatic review settings November 11, 2025 13:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a test assertion in the performance advisor integration test that was incorrectly checking for a false value when the actual expected value is undefined.

  • Corrects the expected value for response.isError from false to undefined

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@blva blva enabled auto-merge (squash) November 11, 2025 13:27
@blva blva merged commit 2764d04 into main Nov 11, 2025
18 checks passed
@blva blva deleted the fix-perf-advisor-test branch November 11, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants