fix(server-provider-core): don't import MapReduceOptions from Node driver #1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jan 9, 2023
| @@ -0,0 +1,30 @@ | |||
| import { CommandOperationOptions, Document, ObjectId, Sort } from 'mongodb'; | |||
There was a problem hiding this comment.
Suggested change
| import { CommandOperationOptions, Document, ObjectId, Sort } from 'mongodb'; | |
| import type { CommandOperationOptions, Document, ObjectId, Sort } from 'mongodb'; |
(we don’t have a nice imports autoformatter like y’all do for the driver, but we do prefer import type where applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mongodb/node-mongodb-native#3511 removes support for
MapReducein the Node driver.This PR moves
MapReduceOptionsandFinalizeFunctionfrom the driver into mongosh.Alternatively, we could replace
MapReduceOptionswithDocumentinstead of moving the definition out of the driver but since it's only two small interfaces, I felt that it's not a huge burden to maintain.Example CI run from the driver with no MapReduce and the changes in this PR: https://spruce.mongodb.com/version/63bc2438d6d80a31a0a43fb3/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC