-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NODE-6578): add misc tooling to ZSTD repo #36
base: main
Are you sure you want to change the base?
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
1170891
to
5284027
Compare
analyze: | ||
name: Analyze (${{ matrix.language }}) | ||
runs-on: "ubuntu-latest" | ||
timeout-minutes: 360 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL only takes about 2 minutes, is there a reason we put a timeout here and chose 360?
@@ -2,13 +2,19 @@ | |||
ARG PLATFORM=arm64 | |||
ARG NODE_VERSION=16.20.1 | |||
|
|||
FROM ${PLATFORM}/node:${NODE_VERSION}-alpine AS node | |||
FROM ${PLATFORM}/node:${NODE_VERSION}-alpine AS build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation behind this change?
Description
What is changing?
This PR contains a smattering of tooling we'll need for the SSDLC release flow (coming in the next PR):
build
action has been added, that builds the bindings and uploads the to GHA artifact storage (for use in the release action later, coming in a follow-up PR)Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run format:js && npm run format:rs
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript