Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer version of oscrypto for OCSP mock server #452

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

alcaeus
Copy link
Contributor

@alcaeus alcaeus commented Jun 27, 2024

The stable version of oscrypto has a bug that prevents it from working with OpenSSL 3.0.10:

Traceback (most recent call last):
[2024/06/27 14:49:14.487]   File "/data/mci/91c84d5568444dead3a62ac8435331d4/drivers-tools/.evergreen/ocsp/ocsp_mock.py", line 13, in <module>
[2024/06/27 14:49:14.487]     import mock_ocsp_responder
[2024/06/27 14:49:14.487]   File "/data/mci/91c84d5568444dead3a62ac8435331d4/drivers-tools/.evergreen/ocsp/mock_ocsp_responder.py", line 56, in <module>
[2024/06/27 14:49:14.487]     from oscrypto import asymmetric
[2024/06/27 14:49:14.487]   File "/data/mci/91c84d5568444dead3a62ac8435331d4/drivers-tools/.evergreen/ocsp/ocspvenv/lib/python3.10/site-packages/oscrypto/asymmetric.py", line 19, in <module>
[2024/06/27 14:49:14.487]     from ._asymmetric import _unwrap_private_key_info
[2024/06/27 14:49:14.487]   File "/data/mci/91c84d5568444dead3a62ac8435331d4/drivers-tools/.evergreen/ocsp/ocspvenv/lib/python3.10/site-packages/oscrypto/_asymmetric.py", line 27, in <module>
[2024/06/27 14:49:14.487]     from .kdf import pbkdf1, pbkdf2, pkcs12_kdf
[2024/06/27 14:49:14.487]   File "/data/mci/91c84d5568444dead3a62ac8435331d4/drivers-tools/.evergreen/ocsp/ocspvenv/lib/python3.10/site-packages/oscrypto/kdf.py", line 9, in <module>
[2024/06/27 14:49:14.487]     from .util import rand_bytes
[2024/06/27 14:49:14.487]   File "/data/mci/91c84d5568444dead3a62ac8435331d4/drivers-tools/.evergreen/ocsp/ocspvenv/lib/python3.10/site-packages/oscrypto/util.py", line 14, in <module>
[2024/06/27 14:49:14.487]     from ._openssl.util import rand_bytes
[2024/06/27 14:49:14.487]   File "/data/mci/91c84d5568444dead3a62ac8435331d4/drivers-tools/.evergreen/ocsp/ocspvenv/lib/python3.10/site-packages/oscrypto/_openssl/util.py", line 6, in <module>
[2024/06/27 14:49:14.487]     from ._libcrypto import libcrypto, libcrypto_version_info, handle_openssl_error
[2024/06/27 14:49:14.487]   File "/data/mci/91c84d5568444dead3a62ac8435331d4/drivers-tools/.evergreen/ocsp/ocspvenv/lib/python3.10/site-packages/oscrypto/_openssl/_libcrypto.py", line 15, in <module>
[2024/06/27 14:49:14.487]     from ._libcrypto_ctypes import (
[2024/06/27 14:49:14.487]   File "/data/mci/91c84d5568444dead3a62ac8435331d4/drivers-tools/.evergreen/ocsp/ocspvenv/lib/python3.10/site-packages/oscrypto/_openssl/_libcrypto_ctypes.py", line 47, in <module>
[2024/06/27 14:49:14.487]     raise LibraryNotFoundError('Error detecting the version of libcrypto')

This PR updates to an unstable version of oscrypto while we're waiting for a stable release.

I've tested the change in the PHP driver and it fixes the broken OCSP tests.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alcaeus alcaeus merged commit 4483bcc into mongodb-labs:master Jun 27, 2024
15 of 16 checks passed
@alcaeus alcaeus deleted the fix-oscrypto-modern-ssl branch June 27, 2024 14:19
adriandole pushed a commit to adriandole/drivers-evergreen-tools that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants