♻️ CODE REFACTOR #40
Merged
♻️ CODE REFACTOR #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added .idea to gitignore file
refactored backend_cors_origin field in config to use annotated and BeforeValidator instead of the field validator decorator anymore and changed rstrip to strip in the
According to best practices and PEP 604, instead of Optional[Type], one should use Type | None, argument backed by [Link](https://discuss.python.org/t/clarification-for-pep-604-is-foo-int-none-to-replace-all-use-of-foo-optional-int/26945)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored backend_cors_origin field in config to use annotated and BeforeValidator instead of the field validator decorator anymore and changed from rstrip to strip in main when calling backend_cors_origin
move from Optional[Type] = None to Type | None = None, This proposed change is well an argument but the below discussion link is a clarification to PEP 604 – Allow writing union types as X | Y
Python discussion