Skip to content

[Bugfix] Remove SecretStr from Token Schema #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2024
Merged

[Bugfix] Remove SecretStr from Token Schema #45

merged 1 commit into from
May 15, 2024

Conversation

Jibola
Copy link
Collaborator

@Jibola Jibola commented May 14, 2024

Bugfix

class Token(BaseModel):
    access_token: SecretStr
    refresh_token: SecretStr
    token_type: str

Caused errors when transmitting a payload to the frontend. The frontend subsequently read the input as access_token: '*****' making users unable to leverage the login functionality. This fix returns the it back to using str.

@caseyclements caseyclements self-requested a review May 14, 2024 20:59
caseyclements
caseyclements approved these changes May 14, 2024
View reviewed changes
Copy link

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jibola Jibola merged commit 47e3fa5 into main May 15, 2024
@Jibola Jibola mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyclements caseyclements caseyclements approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jibola @caseyclements