Optimize BSON for rechecks & mismatches. #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
changed the title
tdq45gj
approved these changes
Nov 10, 2025
Collaborator
tdq45gj
left a comment
tdq45gj
left a comment
There was a problem hiding this comment.
LGTM. I've left some minor comments.
Comment on lines
+35
to
+40
| bsonLen := 4 + // header | ||
| 1 + 4 + 1 + len(bson.ObjectID{}) + // Task | ||
| 1 + 6 + 1 + len(detail) + // Detail | ||
| 1 // NUL | ||
|
|
||
| buf := make(bson.Raw, 4, bsonLen) |
Collaborator
There was a problem hiding this comment.
I wonder how much faster it is compared to using DocumentBuilder.
Collaborator
Author
There was a problem hiding this comment.
DocumentBuilder doesn’t have a way to preallocate a buffer, unfortunately. Every field it adds does a reallocation.
|
|
||
| connStr := os.Getenv("MVTEST_META") | ||
| if connStr == "" { | ||
| t.Skipf("No MVTEST_META found; skipping.") |
Collaborator
There was a problem hiding this comment.
Is it possible to use the source or destination URI instead of skipping?
Collaborator
Author
There was a problem hiding this comment.
Anything that sets a src or dst in env has probably also set a meta. IMO not worth accommodating something that hasn’t.
Co-authored-by: Jian Guan <61915096+tdq45gj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes a few BSON marshal/unmarshal operations:
This also includes a new UnmarshalCursor function that works like mongo.Cursor.All but for structs that implement UnmarshalFromBSON (and forbid bson.Unmarshal).
It also fixes 2 intermittently-failing tests: