Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyMethodDef warnings resolve #42 #49

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ShaneHarvey
Copy link
Collaborator

@ShaneHarvey ShaneHarvey commented Aug 1, 2023

Resolves #42

See https://docs.python.org/3/extending/extending.html?highlight=meth_varargs%20meth_keywords#keyword-parameters-for-extension-functions:

static PyMethodDef keywdarg_methods[] = {
    /* The cast of the function is necessary since PyCFunction values
     * only take two PyObject* parameters, and keywdarg_parrot() takes
     * three.
     */
    {"parrot", (PyCFunction)(void(*)(void))keywdarg_parrot, METH_VARARGS | METH_KEYWORDS,
     "Print a lovely skit to standard output."},
    {NULL, NULL, 0, NULL}   /* sentinel */
};

@ShaneHarvey ShaneHarvey requested a review from blink1073 as a code owner August 1, 2023 17:13
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShaneHarvey ShaneHarvey merged commit 5acc4d2 into mongodb-labs:master Aug 1, 2023
@ShaneHarvey ShaneHarvey deleted the fix-42 branch August 1, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix initialization from incompatible pointer type compile warnings
2 participants