PYTHON-4320 Add Support for Python 3.13 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
commented
Sep 4, 2024
bsonjs/bson/bson-error.c
Outdated
| @@ -109,8 +109,6 @@ bson_strerror_r (int err_code, /* IN */ | |||
| if (strerror_s (buf, buflen, err_code) != 0) { | |||
| ret = buf; | |||
| } | |||
| #elif defined(__GNUC__) && defined(_GNU_SOURCE) | |||
| ret = strerror_r (err_code, buf, buflen); | |||
| #else /* XSI strerror_r */ | |||
There was a problem hiding this comment.
As of glibc 2.13, we can assume XSI compliance. manylinux_2014 includes gcc 2.17.
ShaneHarvey
reviewed
Sep 4, 2024
bsonjs/bson/bson-version.h
Outdated
| @@ -69,7 +69,7 @@ | |||
| * BSON version, encoded as a string, useful for printing and | |||
| * concatenation. | |||
| */ | |||
| #define BSON_VERSION_S "1.24.2" | |||
| #define BSON_VERSION_S "" | |||
There was a problem hiding this comment.
Is it expected that BSON_VERSION and BSON_VERSION_S are empty?
There was a problem hiding this comment.
It was an issue with the vendor script, updated.
| @@ -1,6 +1,14 @@ | |||
| Changelog | |||
| ========= | |||
|
|
|||
| 0.5.0 | |||
| ````` | |||
| For a detailed breakdown of what changed in each version of libbson see its changelog: | |||
There was a problem hiding this comment.
Add:
Version 0.5.0 updates python-bsonjs's vendored copy of libbson to 1.27.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump the vendored bson drivers in preparation for release.