Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move lazy_static to once_cell #416

Merged
merged 2 commits into from
Jun 8, 2023
Merged

move lazy_static to once_cell #416

merged 2 commits into from
Jun 8, 2023

Conversation

attila-lin
Copy link
Contributor

No description provided.

@abr-egn abr-egn self-requested a review June 7, 2023 14:18
@abr-egn
Copy link
Contributor

abr-egn commented Jun 7, 2023

Thanks for contributing this! I've authorized the evergreen run and assuming all tests pass I'll merge this in.

@abr-egn
Copy link
Contributor

abr-egn commented Jun 7, 2023

Looks like there's just a single clippy warning - fix that up and it'll be good to merge!

[2023/06/07 14:21:30.598] error: redundant closure
[2023/06/07 14:21:30.598]   --> src/tests/mod.rs:10:52
[2023/06/07 14:21:30.598]    |
[2023/06/07 14:21:30.598] 10 | pub(crate) static LOCK: Lazy<TestLock> = Lazy::new(|| TestLock::new());
[2023/06/07 14:21:30.598]    |                                                    ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `TestLock::new`

@attila-lin
Copy link
Contributor Author

@abr-egn fixed it~

@abr-egn abr-egn merged commit b637094 into mongodb:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abr-egn abr-egn abr-egn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attila-lin @abr-egn