RUST-1764 Add HumanReadable convenience wrapper
#471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, we should also remove the option from |
| @@ -454,12 +458,16 @@ impl<'de, 'a> serde::de::Deserializer<'de> for &'a mut Deserializer<'de> { | |||
|
|
|||
| self.deserialize_next(visitor, DeserializerHint::RawBson) | |||
| } | |||
| HUMAN_READABLE_NEWTYPE => { | |||
| self.human_readable = true; | |||
There was a problem hiding this comment.
Could this be an issue when a HumanReadable<T> is nested in a struct with non-wrapped types following it? e.g.
struct Test {
human_readable: HumanReadable<Document>,
non_human_readable: Document,
}
There was a problem hiding this comment.
Good catch! I've fixed the logic and updated the test to flag that kind of failure.
isabelatkinson
approved these changes
Apr 5, 2024
SGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1764
This wrapper removes the need for the
human_readable_serializationoption forCollectionand provides more granular control as well. There could hypothetically also be a use for a correspondingNonHumanReadablewrapper but I'd prefer to wait on adding that until someone asks for it.