(EAI-532) [UI] Fix spacing for headings and lists #529
Conversation
|
i think the spacing between list items now looks strangely big. what was the reason for this change? |
| return ( | ||
| <Body as="ol" className={styles.markdown_list} {...props}> | ||
| <Body as="ol" {...props}> |
There was a problem hiding this comment.
should styles.markdown_list be deleted accordingly?
There was a problem hiding this comment.
Yeah it already is. These styles got merged into markdown_container.
@mongodben This is the base styles from LG Chat. I removed some of our hacky negative margin stuff in this PR because more edge cases came up. Still not sure why our list items spread out this much but I think it's (a) not terrible and (b) less complicated to use the out of the box styles rather than hacking around every edge case. |
maybe get sign off from liz before merge + deploy? i'm totally supportive of not hacking around edge cases, but i really think it looks off. maybe at least we could make a ticket for LG chat, or bring to their attention so they can address upstream w/o you having to hack 
|
Jira: (EAI-532) [UI] Fix spacing for headings and lists
