Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(EAI-463): Move ingest logic to mongodb-rag-core #544

Merged
merged 16 commits into from
Oct 30, 2024
Merged

Conversation

mongodben
Copy link
Collaborator

@mongodben mongodben commented Oct 28, 2024

Jira: https://jira.mongodb.org/browse/EAI-463

Changes

  • Move ingestion logic to mongodb-rag-core
  • Create folders in mongodb-rag-core to organize code based on function
  • Export langchain modules from core for usage throughout repo
  • Misc package updates throughout
  • Fewer direct exports from mongodb-rag-ingest. now this logic is in core package.
    • This includes breaking changes to exports of mongodb-rag-ingest for any consumers of the package via npm (once we release these changes to npm)

Notes

@mongodben mongodben marked this pull request as draft October 28, 2024 20:29
@mongodben mongodben marked this pull request as ready for review October 29, 2024 15:37
Copy link
Collaborator

@nlarew nlarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - lots of changes in this one, so it's tough to be 100% confident, but I think this should work. Tests pass at least! Nice work shuffling this all around.

@mongodben mongodben merged commit 68d6107 into main Oct 30, 2024
1 check passed
@mongodben mongodben deleted the EAI-463_redux_pt_2 branch October 30, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants