Support /exports from mongodb-rag-core
#548
Conversation
| @@ -15,14 +16,14 @@ export const makeRadiantChatLlm = async ({ | |||
| deployment: string; | |||
| mongoDbAuthCookie?: string; | |||
| lmmConfigOptions: Pick< | |||
| OpenAI.default.Chat.ChatCompletionCreateParams, | |||
| OpenAI.Chat.ChatCompletionCreateParams, | |||
There was a problem hiding this comment.
I don't dislike the namespaced types here (very explicit what it is!). Is it possible to import just ChatCompletionCreateParams without the whole OpenAI namespace?
There was a problem hiding this comment.
i dont think so. dont think it's a real issue tho b/c the benchmarks package is only being built in this repo, which will already install all of mongodb-rag-core, which is dependent on the openai package
packages/chatbot-server-mongodb-public/src/processors/makeStepBackUserQuery.test.ts
Show resolved
Hide resolved
packages/chatbot-server-mongodb-public/src/processors/userMessageMongoDbGuardrail.test.ts
Show resolved
Hide resolved
| @@ -1,33 +1,29 @@ | |||
| export const makeMockOpenAIToolCall = (funcRes: Record<string, unknown>) => { | |||
| // This module is also required for the mock to work | |||
| // in the tests | |||
| const { updateFrontMatter } = jest.requireActual("mongodb-chatbot-server"); | |||
There was a problem hiding this comment.
No longer required? Should we delete the comment above it too?
There was a problem hiding this comment.
def delete comment too. will implement
| // LLM function | ||
| const translator = createJsonTranslator<SchemaType>( | ||
| model, | ||
| const validator = createTypeScriptJsonValidator<SchemaType>( |
There was a problem hiding this comment.
Why update our TypeChat code? Is there a new version?
There was a problem hiding this comment.
I don't see a version bump in the diff - do we need to update scripts/package.json?
There was a problem hiding this comment.
maybe? i'll set the version in package.json to whatever is most recent
There was a problem hiding this comment.
version in package.json is the latest. i'm confused what's going on, but will keep as is since it works and i dont think this usage is important enough for us to worry too much about
| "module": "NodeNext", | ||
| "moduleResolution": "NodeNext", |
There was a problem hiding this comment.
There are some considerable implications in changing the module format. I think this is something we should do, but we'll want to monitor for impact + maybe do a major version bump
There was a problem hiding this comment.
i think the main implication of switching to NodeNext is that now it supports both common js and esm by default rather than just commonjs.
Jira: n/a
Changes
/exports. To make this work, I had to add the following to the roottsconfig.json:/exportmongodb-rag-corepackagechatbot-eval-mongodb-public(it's unused)mongodb-chatbot-evaluationb/c it has some modules used in benchmarks. we should remove that and move the modules over in a separate PR.Notes